Re: [PATCH 1/1] PCI: Add translated request only opt-in for pci_enable_pasid()

From: Bjorn Helgaas
Date: Thu Jan 12 2023 - 13:59:11 EST


On Thu, Jan 12, 2023 at 09:25:25PM +0800, Baolu Lu wrote:
> On 2023/1/12 20:38, Jason Gunthorpe wrote:
> > On Thu, Jan 12, 2023 at 04:46:29PM +0800, Lu Baolu wrote:
> >
> > > -int pci_enable_pasid(struct pci_dev *pdev, int features);
> > > +int pci_enable_pasid(struct pci_dev *pdev, int features, bool
> > > transled_only);
^^^^^^^^

> + * @flags: device-specific flags
> + * - PCI_PASID_TRANSLED_REQ_ONLY: The PCI device only issues PASID
> + * memory requests of translated type.
^^^^^^^^

I don't like "transled" since it's not a word itself or an obvious
combination of "translated" and something else.

Not sure whether you need to abbreviate it, but if you do, "xlate" is
a common shortening of "translate".

Bjorn