Re: [PATCH] platform/x86: asus-nb-wmi: Add alternate mapping for KEY_CAMERA

From: Hans de Goede
Date: Thu Jan 12 2023 - 13:50:26 EST


Hi,

On 12/21/22 04:49, Thomas Weißschuh wrote:
> This keycode is emitted on a Asus VivoBook E410MAB with firmware
> E410MAB.304.
>
> The physical key has a strikken-through camera printed on it.
>
> Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>

Thank you for your patch, I've applied this patch to my fixes
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes

Note it will show up in my fixes branch once I've pushed my
local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans


> ---
> drivers/platform/x86/asus-nb-wmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index c685a705b73d..8ee5d108e9e0 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -544,6 +544,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
> { KE_KEY, 0x7D, { KEY_BLUETOOTH } }, /* Bluetooth Enable */
> { KE_KEY, 0x7E, { KEY_BLUETOOTH } }, /* Bluetooth Disable */
> { KE_KEY, 0x82, { KEY_CAMERA } },
> + { KE_KEY, 0x85, { KEY_CAMERA } },
> { KE_KEY, 0x86, { KEY_PROG1 } }, /* MyASUS Key */
> { KE_KEY, 0x88, { KEY_RFKILL } }, /* Radio Toggle Key */
> { KE_KEY, 0x8A, { KEY_PROG1 } }, /* Color enhancement mode */
>
> ---
> base-commit: b6bb9676f2165d518b35ba3bea5f1fcfc0d969bf
> change-id: 20221216-asus-key-b3bfb3bc2e77
>
> Best regards,