RE: [PATCH v2 3/5] iio: pressure: bmp280: Add support for new sensor BMP580

[Contact Bosch-Sensortec (BST/SA)]

Dear Jonathan and Angel,

Aligned with our product management, we can confirm that the CHIP-IDs are identiacal, this is correct.


Best regards,

Bosch Sensortec Sales Support

Bosch Sensortec GmbH | Gerhard-Kindler-Straße 9 | 72770 Reutlingen | GERMANY | www.bosch-sensortec.com 


Sitz: Kusterdingen, Registergericht: Stuttgart HRB 382674,
Ust.IdNr. DE 183276693 - Steuer-Nr. 99012/08040
Geschäftsführung: Stefan Finkbeiner, Jens-Knut Fabrowsky



-----Original Message-----
From: Jonathan Cameron <jic23@xxxxxxxxxx> 
Sent: Sonntag, 8. Januar 2023 13:35
To: Angel Iglesias <ang.iglesiasg@xxxxxxxxx>
Cc: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>; ak@xxxxxxxxxxxxx; andriy.shevchenko@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; lars@xxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; nikita.yoush@xxxxxxxxxxxxxxxxxx; paul@xxxxxxxxxxxxxxx; rafael.j.wysocki@xxxxxxxxx; robh+dt@xxxxxxxxxx; ulf.hansson@xxxxxxxxxx; Contact Bosch-Sensortec (BST/SA) <contact@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 3/5] iio: pressure: bmp280: Add support for new sensor BMP580

On Sun, 01 Jan 2023 12:16:28 +0100
Angel Iglesias <ang.iglesiasg@xxxxxxxxx> wrote:

> On Fri, 2022-12-30 at 18:22 +0000, Jonathan Cameron wrote:
> > On Thu, 29 Dec 2022 19:23:16 +0100
> > Angel Iglesias <ang.iglesiasg@xxxxxxxxx> wrote:
> >   
> > > On Thu, 2022-12-29 at 18:35 +0100, Christophe JAILLET wrote:  
> > > > Le 26/12/2022 à 15:29, Angel Iglesias a écrit :    
> > > > > Adds compatibility with the new sensor generation, the BMP580.
> > > > > 
> > > > > The measurement and initialization codepaths are adapted from 
> > > > > the device datasheet and the repository from manufacturer at 
> > > > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fboschsensortec%2FBMP5-Sensor-API&data=05%7C01%7Ccontact%40bosch-sensortec.com%7C5df3784517c940394e8308daf172e38e%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C638087774478147184%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=YarsZiHIZ%2FBkNNqK%2FunjfVWGgIwOtvf%2BPXs8ipHQdRQ%3D&reserved=0.
> > > > > 
> > > > > Signed-off-by: Angel Iglesias
> > > > > <ang.iglesiasg-Re5JQEeQqe8AvxtiuMwx3w@xxxxxxxxxxxxxxxx>
> > > > >     
> > > > 
> > > > [...]
> > > >     
> > > > > diff --git a/drivers/iio/pressure/bmp280.h 
> > > > > b/drivers/iio/pressure/bmp280.h index 
> > > > > efc31bc84708..27d2abc17d01 100644
> > > > > --- a/drivers/iio/pressure/bmp280.h
> > > > > +++ b/drivers/iio/pressure/bmp280.h    
> > > > 
> > > > [...]
> > > >     
> > > > > +#define BMP580_CHIP_ID                 0x50
> > > > >   #define BMP380_CHIP_ID                        0x50    
> > > > 
> > > > Hi,
> > > > 
> > > > this is maybe correct (I've not been able to find the datasheet to check 
> > > > myself), but it looks odd to have the same ID for 2 different chips.    
> > > 
> > > Yes, I also couldn't find a datasheet for the BMP580 or a devkit anywhere.
> > > I'm
> > > developing this using the BMP581, which seems to be a variant 
> > > almost identical.
> > > Something similar happened with the BMP38x; you could find the 
> > > BMP384 and the BMP388, but the BMP380 was unavailable everywhere, 
> > > datasheet included. My guess is this is a similar situation. In 
> > > any case, the datasheet of the BMP581 is available here:
> > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> > > www.bosch-sensortec.com%2Fmedia%2Fboschsensortec%2Fdownloads%2Fdat
> > > asheets%2Fbst-bmp581-ds004.pdf&data=05%7C01%7Ccontact%40bosch-sens
> > > ortec.com%7C5df3784517c940394e8308daf172e38e%7C0ae51e1907c84e4bbb6
> > > d648ee58410f4%7C0%7C0%7C638087774478147184%7CUnknown%7CTWFpbGZsb3d
> > > 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> > > D%7C3000%7C%7C%7C&sdata=dNnnClouPfqXntLuTWGQovRw39ehaLeuzKuN%2FNWI
> > > 8y0%3D&reserved=0
> > > 
> > > Regarding the chip id being the same between generations is weird, 
> > > but at least the datasheet and the sensor I have uses 0x50 as the 
> > > chip id. After you mentioned this, I checked back on the reference 
> > > API repository from Bosch and it has both 0x50 and 0x51 as valid 
> > > IDs:
> > > *
> > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> > > github.com%2Fboschsensortec%2FBMP5-Sensor-API%2Fblob%2Fmaster%2Fbm
> > > p5_defs.h%23L198&data=05%7C01%7Ccontact%40bosch-sensortec.com%7C5d
> > > f3784517c940394e8308daf172e38e%7C0ae51e1907c84e4bbb6d648ee58410f4%
> > > 7C0%7C0%7C638087774478147184%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL
> > > jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C
> > > %7C&sdata=tZgYdnxpvKIndjtJaaFfcAJbBa4%2FcIgKhb4XH6sAO9A%3D&reserve
> > > d=0
> > > * 
> > > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> > > github.com%2Fboschsensortec%2FBMP5-Sensor-API%2Fblob%2Fmaster%2Fbm
> > > p5.c%23L1444&data=05%7C01%7Ccontact%40bosch-sensortec.com%7C5df378
> > > 4517c940394e8308daf172e38e%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%
> > > 7C0%7C638087774478147184%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM
> > > DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&
> > > sdata=xU9Yh2zXjol0vyF9iltRmkBK3CUlGGdcjrp3AzwvTNU%3D&reserved=0
> > https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgi
> > thub.com%2Fboschsensortec%2FBMP3-Sensor-API%2Fblob%2Fmaster%2Fbmp3_d
> > efs.h&data=05%7C01%7Ccontact%40bosch-sensortec.com%7C5df3784517c9403
> > 94e8308daf172e38e%7C0ae51e1907c84e4bbb6d648ee58410f4%7C0%7C0%7C63808
> > 7774478147184%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2
> > luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=faQZ4qjLF
> > jfYN2US64FbZJo%2B5lOuFw52mIY3XqoXDKU%3D&reserved=0
> > I was curious on whether we had a wrong value for bmp380, but nope... Same ID.
> > 
> > Huh. As per earlier comment - who wants to moan at Bosch as this is 
> > crazy situation?
> > 
> > Jonathan
> 
> Well I'm doing this in my free time beacuse I wanted to setup a meteo 
> station and got annoyed needing to patch-up userspace code for reading 
> pressure and temperature sensors on a very underpowered ARM device 
> when there is a kernel subsystem for this kind of things. The rest is history on the mailing list.
> I don't think I have any leverage to have Bosch listening to my 
> complaints

Sadly I don't have a good contact in Bosch. So all we can do is +CC the contact address.

If anyone else has a good channel to point out this silliness please do!

Jonathan

> 
> Angel
> 
> >   
> > > 
> > > Angel
> > >   
> > > > CJ
> > > >     
> > > > >   #define BMP180_CHIP_ID                        0x55
> > > > >   #define BMP280_CHIP_ID                        0x58    
> > > >     
> > >   
> >   
>