Re: [PATCH v10 0/9] Register Type-C mode-switch in DP bridge endpoints

From: Dmitry Baryshkov
Date: Wed Jan 11 2023 - 23:35:13 EST


On 12/01/2023 06:20, Pin-yen Lin wrote:

This series introduces bindings for anx7625/it6505 to register Type-C
mode-switch in their output endpoints, and use data-lanes property to
describe the pin connections.

Please cc everybody on all patches. Having received just a single patch made me spend time on having to look them up on lore.


The first two patch modifies fwnode_graph_devcon_matches and
cros_typec_init_ports to enable the registration of the switches.

Patch 4~6 introduce the bindings for anx7625 and the corresponding driver
modifications.

Patch 7~9 add similar bindings and driver changes for it6505.

v9: https://lore.kernel.org/all/20230109084101.265664-1-treapking@xxxxxxxxxxxx/
v8: https://lore.kernel.org/all/20230107102231.23682-1-treapking@xxxxxxxxxxxx/
v7: https://lore.kernel.org/all/20230105132457.4125372-1-treapking@xxxxxxxxxxxx/
v6: https://lore.kernel.org/all/20221124102056.393220-1-treapking@xxxxxxxxxxxx/
v5: https://lore.kernel.org/linux-usb/20220622173605.1168416-1-pmalani@xxxxxxxxxxxx/

Changes in v10:
- Collected Reviewed-by and Tested-by tags
- Replaced "void *" with "typec_mux_set_fn_t" for mux_set callbacks
- Print out the node name when errors on parsing DT
- Use dev_dbg instead of dev_warn when no Type-C switch nodes available
- Made the return path of drm_dp_register_mode_switch clearer
- Added a TODO for implementing orientation switch for anx7625
- Updated the commit message for the absence of orientation switch
- Fixed typo in the commit message

Changes in v9:
- Collected Reviewed-by tag
- Fixed subject prefix again
- Changed the naming of the example node for it6505

Changes in v8:
- Fixed the build issue when CONFIG_TYPEC=m
- Fixed some style issues
- Fixed the subject prefixes for the bindings patch
- Fixed the bindings for data-lanes properties

Changes in v7:
- Fix the long comment lines
- Extracted the common codes to a helper function
- Fixed style issues in anx7625 driver
- Removed DT property validation in anx7625 driver.
- Fixed style issues in it6505 driver
- Removed the redundant sleep in it6505 driver
- Removed DT property validation in it6505 driver
- Rebased to drm-misc-next
- Fixed indentations in bindings patches
- Added a new patch to fix indentations in Kconfig

Changes in v6:
- Changed it6505_typec_mux_set callback function to accommodate with
the latest drm-misc patches
- Changed the driver implementation to accommodate with the new binding
- Dropped typec-switch binding and use endpoints and data-lanes properties
to describe the pin connections
- Added new patches (patch 1,2,4) to fix probing issues
- Changed the bindings of it6505/anx7625 and modified the drivers
accordingly
- Merged it6505/anx7625 driver changes into a single patch

Pin-yen Lin (7):
drm/display: Add Type-C switch helpers
dt-bindings: display: bridge: anx7625: Add mode-switch support
drm/bridge: anx7625: Check for Type-C during panel registration
drm/bridge: anx7625: Register Type C mode switches
dt-bindings: display: bridge: it6505: Add mode-switch support
drm/bridge: it6505: Fix Kconfig indentation
drm/bridge: it6505: Register Type C mode switches

Prashant Malani (2):
device property: Add remote endpoint to devcon matcher
platform/chrome: cros_ec_typec: Purge blocking switch devlinks

.../display/bridge/analogix,anx7625.yaml | 99 ++++++++++++-
.../bindings/display/bridge/ite,it6505.yaml | 93 ++++++++++--
drivers/base/property.c | 15 ++
drivers/gpu/drm/bridge/Kconfig | 21 +--
drivers/gpu/drm/bridge/analogix/Kconfig | 1 +
drivers/gpu/drm/bridge/analogix/anx7625.c | 105 +++++++++++++-
drivers/gpu/drm/bridge/analogix/anx7625.h | 13 ++
drivers/gpu/drm/bridge/ite-it6505.c | 119 +++++++++++++++-
drivers/gpu/drm/display/drm_dp_helper.c | 134 ++++++++++++++++++
drivers/platform/chrome/cros_ec_typec.c | 10 ++
include/drm/display/drm_dp_helper.h | 17 +++
11 files changed, 598 insertions(+), 29 deletions(-)


--
With best wishes
Dmitry