Re: [PATCH] caif: don't assume iov_iter type

From: Jens Axboe
Date: Wed Jan 11 2023 - 16:58:53 EST


On 1/11/23 11:42 AM, Keith Busch wrote:
> From: Keith Busch <kbusch@xxxxxxxxxx>
>
> The details of the iov_iter types are appropriately abstracted, so
> there's no need to check for specific type fields. Just let the
> abstractions handle it.
>
> This is preparing for io_uring/net's io_send to utilize the more
> efficient ITER_UBUF.

Looks good to me - the correct return here would be -EFAULT as well,
not -EINVAL. Which is what will happen once memcpy_from_msg() is
called anyway.

Reviewed-by: Jens Axboe <axboe@xxxxxxxxx>

--
Jens Axboe