Re: [PATCH v3 08/13] tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool active

From: Johan Hovold
Date: Wed Jan 11 2023 - 12:30:02 EST


On Wed, Jan 11, 2023 at 04:23:26PM +0200, Ilpo Järvinen wrote:
> Convert status parameter for ->dcd_change() and
> uart_handle_dcd_change() to bool which matches to how the parameter is
> used.
>
> Rename status to active to better describe what the parameter means.
>
> Acked-by: Rodolfo Giometti <giometti@xxxxxxxxxxxx>
> Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> ---
> drivers/pps/clients/pps-ldisc.c | 6 +++---
> drivers/tty/serial/serial_core.c | 8 ++++----
> drivers/tty/serial/sunhv.c | 8 ++++----
> drivers/usb/serial/generic.c | 10 +++++-----
> include/linux/serial_core.h | 3 +--
> include/linux/tty_ldisc.h | 4 ++--
> include/linux/usb/serial.h | 2 +-
> 7 files changed, 20 insertions(+), 21 deletions(-)

Same here, split out the USB serial changes in a separate series.

Johan