Re: [PATCH v1 1/1] selftests/filesystems: Grant executable permission to run_fat_tests.sh

From: Javier Martinez Canillas
Date: Wed Jan 11 2023 - 09:48:17 EST


Hello Pengfei Xu,

On 1/11/23 09:15, Pengfei Xu wrote:
> When use tools/testing/selftests/kselftest_install.sh to make the
> kselftest-list.txt under tools/testing/selftests/kselftest_install.
>
> Then use tools/testing/selftests/kselftest_install/run_kselftest.sh to
> run all the kselftests in kselftest-list.txt, it will be blocked by
> case "filesystems/fat: run_fat_tests.sh" with "Warning: file run_fat_tests.sh
> is not executable", so grant executable permission to run_fat_tests.sh to
> fix this issue.
>
> Fixes: dd7c9be330d8 ("selftests/filesystems: add a vfat RENAME_EXCHANGE test")
> Signed-off-by: Pengfei Xu <pengfei.xu@xxxxxxxxx>
> ---

Indeed, thanks for fixing this.

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

I wonder how I didn't get this when running the test with:

make TARGETS="filesystems/fat" kselftest

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat