Re: [f2fs-dev] [PATCH v2] f2fs: retry to update the inode page given EIO

[Chao Yu]

On 2023/1/11 9:20, Jaegeuk Kim wrote:
> In f2fs_update_inode_page, f2fs_get_node_page handles EIO along with
> f2fs_handle_page_eio that stops checkpoint, if the disk couldn't be recovered.
> As a result, we don't need to stop checkpoint right away given single EIO.

f2fs_handle_page_eio() only covers the case that EIO occurs on the same
page, should we cover the case EIO occurs on different pages?

Thanks,

> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Randall Huang <huangrandall@xxxxxxxxxx>
> Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>
> ---
>
>   Change log from v1:
>    - fix a bug
>
>   fs/f2fs/inode.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
> index ff6cf66ed46b..2ed7a621fdf1 100644
> --- a/fs/f2fs/inode.c
> +++ b/fs/f2fs/inode.c
> @@ -719,7 +719,7 @@ void f2fs_update_inode_page(struct inode *inode)
>   	if (IS_ERR(node_page)) {
>   		int err = PTR_ERR(node_page);
>   
> -		if (err == -ENOMEM) {
> +		if (err == -ENOMEM || (err == -EIO && !f2fs_cp_error(sbi))) {
>   			cond_resched();
>   			goto retry;
>   		} else if (err != -ENOENT) {