Re: [PATCH] thermal/drivers/qcom: Remove duplicate set next trip point interrupt code

[Daniel Lezcano]

On 10/01/2023 19:13, Bjorn Andersson wrote:
> On Tue, Jan 10, 2023 at 11:34:20AM +0100, Daniel Lezcano wrote:
> > From: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> >
> > The tsens driver reprogram the next trip points in the irq
> > handler. This function then call thermal_zone_device_update().
> >
> > However, thermal_zone_device_update() calls thermal_zone_set_trips()
> > and from there it calls the backend 'set_trips' ops. This one in turn
> > reprogram the next trip points (low/high).
> >
> > Consequently, the code setting the next trip points interrupt in the
> > interrupt handle is not needed and could be removed.
>
>
> Reviewed-by: Bjorn Andersson <andersson@xxxxxxxxxx>
>
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
>
> The last one should be the address you sent your patch from, and that
> was the first one. So I think you should drop this one.

Thanks for the review. I'll remove the duplicated SoB.

  -- Daniel


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog