Re: [PATCH v2 12/13] tty: moxa: Rename dtr/rts parameters/variables to active

[Jiri Slaby]

On 10. 01. 23, 13:02, Ilpo Järvinen wrote:
> Use active consistently for naming parameters and variables.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>

> --- a/drivers/tty/moxa.c
> +++ b/drivers/tty/moxa.c
...
> @@ -1881,10 +1881,10 @@ static void MoxaPortFlushData(struct moxa_port *port, int mode)
>    *      Syntax:
>    *      int  MoxaPortGetLineOut(int port, int *dtrState, int *rtsState);

Hmm, this is wrong too ^^. Not sure what introduced the problem.

>    *           int port           : port number (0 - 127)
> - *           bool * dtrState    : pointer to bool to receive the current DTR
> + *           bool * dtr_active  : pointer to bool to receive the current DTR
>    *                                state. (if NULL, this function will not
>    *                                write to this address)
> - *           bool * rtsState    : pointer to bool to receive the current RTS
> + *           bool * rts_active  : pointer to bool to receive the current RTS
>    *                                state. (if NULL, this function will not
>    *                                write to this address)
>    *


--
js
suse labs