Re: [PATCH v3 07/14] blk-mq: make blk_mq_commit_rqs a general function for all commits

[Christoph Hellwig]

On Wed, Jan 11, 2023 at 09:01:52PM +0800, Kemeng Shi wrote:
> 1. rename orignal blk_mq_commit_rqs to blk_mq_plug_commit_rqs as
> trace_block_unplug is only needed when we dispatch request from plug list.

Why?  I think always having the trace even for the commit case seems
very useful for making the traces useful.

> +/* blk_mq_commit_rqs and blk_mq_plug_commit_rqs notify driver using
> + * bd->last that there is no more requests. (See comment in struct

This is not the normal kernel comment style.

> +static void blk_mq_commit_rqs(struct blk_mq_hw_ctx *hctx, int queued)
> +{
> +	if (hctx->queue->mq_ops->commit_rqs && queued) {
> +		hctx->queue->mq_ops->commit_rqs(hctx);
> +	}

No need for the braces.