Re: [PATCH] fs/pipe: Delete unused do_pipe_flags()

From: Al Viro
Date: Tue Jan 10 2023 - 22:15:01 EST


On Wed, Jan 11, 2023 at 11:05:47AM +0800, Chengming Zhou wrote:
> It looks like do_pipe_flags() is not used anywhere and not exported
> too, so delete it. No any functional changes.

What do you mean, not used anywhere?

<checks>

; git grep -n -w do_pipe_flags
arch/alpha/kernel/osf_sys.c:1315: int res = do_pipe_flags(fd, 0);
arch/ia64/kernel/sys_ia64.c:109: retval = do_pipe_flags(fd, 0);
arch/mips/kernel/syscall.c:54: int error = do_pipe_flags(fd, 0);
arch/sh/kernel/sys_sh32.c:31: error = do_pipe_flags(fd, 0);
arch/sparc/kernel/sys_sparc_32.c:81: error = do_pipe_flags(fd, 0);
arch/sparc/kernel/sys_sparc_64.c:319: error = do_pipe_flags(fd, 0);
fs/pipe.c:989:int do_pipe_flags(int *fd, int flags)
include/linux/fs.h:3019:extern int do_pipe_flags(int *, int);
;

A bunch of callers, and it's easy to check that they are not
ifdefed out, etc. - normal live code...