Re: [PATCH 1/8] bnxt_en: Add auxiliary driver support

[Ajit Khaparde]

On Tue, Jan 10, 2023 at 2:51 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Sat,  7 Jan 2023 19:02:01 -0800 Ajit Khaparde wrote:
> > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c
:::: snip ::::
>
> This forward declaration is not needed, at least in this patch.
>
> >  struct bnxt;
> >
> >  struct bnxt_msix_entry {
> > @@ -102,10 +103,14 @@ int bnxt_get_ulp_stat_ctxs(struct bnxt *bp);
> >  void bnxt_ulp_stop(struct bnxt *bp);
> >  void bnxt_ulp_start(struct bnxt *bp, int err);
> >  void bnxt_ulp_sriov_cfg(struct bnxt *bp, int num_vfs);
> > -void bnxt_ulp_shutdown(struct bnxt *bp);
> >  void bnxt_ulp_irq_stop(struct bnxt *bp);
> >  void bnxt_ulp_irq_restart(struct bnxt *bp, int err);
> >  void bnxt_ulp_async_events(struct bnxt *bp, struct hwrm_async_event_cmpl *cmpl);
> > +void bnxt_aux_dev_release(struct device *dev);
> > +int bnxt_rdma_aux_device_add(struct bnxt *bp);
>
> This is only used in bnxt_ulp.c, please remove the declaration and make
> it static. Please check other functions for the same problem.
>
> > +void bnxt_rdma_aux_device_uninit(struct bnxt *bp);
> > +void bnxt_rdma_aux_device_init(struct bnxt *bp);
> > +void bnxt_aux_dev_free(struct bnxt *bp);
>
Thanks Kuba. I will go over the comments and send the next version.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature