Re: [PATCH 3/3] ARM: omap1: fix building gpio15xx

From: Aaro Koskinen
Date: Tue Jan 10 2023 - 16:15:20 EST


Hi,

On Mon, Jan 09, 2023 at 05:16:36PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> In some randconfig builds, the asm/irq.h header is not included
> in gpio15xx.c, so add an explicit include to avoid a build fialure:
>
> In file included from arch/arm/mach-omap1/gpio15xx.c:15:
> arch/arm/mach-omap1/irqs.h:99:34: error: 'NR_IRQS_LEGACY' undeclared here (not in a function)
> 99 | #define IH2_BASE (NR_IRQS_LEGACY + 32)
> | ^~~~~~~~~~~~~~
> arch/arm/mach-omap1/irqs.h:105:38: note: in expansion of macro 'IH2_BASE'
> 105 | #define INT_MPUIO (5 + IH2_BASE)
> | ^~~~~~~~
> arch/arm/mach-omap1/gpio15xx.c:28:27: note: in expansion of macro 'INT_MPUIO'
> 28 | .start = INT_MPUIO,
> | ^~~~~~~~~
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Aaro Koskinen <aaro.koskinen@xxxxxx>

A.

> ---
> arch/arm/mach-omap1/gpio15xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-omap1/gpio15xx.c b/arch/arm/mach-omap1/gpio15xx.c
> index c675f11de99d..61fa26efd865 100644
> --- a/arch/arm/mach-omap1/gpio15xx.c
> +++ b/arch/arm/mach-omap1/gpio15xx.c
> @@ -11,6 +11,7 @@
> #include <linux/gpio.h>
> #include <linux/platform_data/gpio-omap.h>
> #include <linux/soc/ti/omap1-soc.h>
> +#include <asm/irq.h>
>
> #include "irqs.h"
>
> --
> 2.39.0
>