Re: [PATCHv8 3/7] arm64: dts: rockchip: Add base DT for rk3588 SoC

[Sebastian Reichel]

Hi,

On Tue, Jan 10, 2023 at 02:32:29PM +0100, Heiko Stübner wrote:
> Am Dienstag, 10. Januar 2023, 13:17:54 CET schrieb Sebastian Reichel:
> > Hi,
> > 
> > On Tue, Jan 10, 2023 at 12:47:23PM +0100, Heiko Stübner wrote:
> > > Hi Sebastian,
> > > 
> > > Am Montag, 9. Januar 2023, 16:57:57 CET schrieb Sebastian Reichel:
> > > > From: Kever Yang <kever.yang@xxxxxxxxxxxxxx>
> > > > 
> > > > This initial version supports CPU, dma, interrupts, timers, UART and
> > > > SDHCI (everything necessary to boot Linux on this system on chip) as
> > > > well as Ethernet, I2C, PWM and SPI.
> > > > 
> > > > The DT is split into rk3588 and rk3588s, which is a reduced version
> > > > (i.e. with less peripherals) of the former.
> > > > 
> > > > Signed-off-by: Yifeng Zhao <yifeng.zhao@xxxxxxxxxxxxxx>
> > > > Signed-off-by: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx>
> > > > Signed-off-by: Sugar Zhang <sugar.zhang@xxxxxxxxxxxxxx>
> > > > Signed-off-by: Kever Yang <kever.yang@xxxxxxxxxxxxxx>
> > > > [rebase, squash and reword commit message]
> > > 
> > > I guess that means the list of Rockchip Signed-off-by lines above come
> > > from the squashed patches?
> > > 
> > > If so, I guess I should add Co-Developed-by lines for them, as right now
> > > the list is incorrect (author should be first, then everyone through
> > > whose hands a patch went)
> > > 
> > > Meaning I can add those Co-Developed-by lines, so no need to resend,
> > > I'm just verifying what I assume about the lines :-)
> > 
> > Yes, those are SoB lines from squashed downstream commits.
> 
> so I've made the block into 
> Co-Developed-by: Yifeng Zhao <yifeng.zhao@xxxxxxxxxxxxxx>
> Signed-off-by: Yifeng Zhao <yifeng.zhao@xxxxxxxxxxxxxx>
> Co-Developed-by: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx>
> Signed-off-by: Elaine Zhang <zhangqing@xxxxxxxxxxxxxx>
> Co-Developed-by: Sugar Zhang <sugar.zhang@xxxxxxxxxxxxxx>
> Signed-off-by: Sugar Zhang <sugar.zhang@xxxxxxxxxxxxxx>
> Signed-off-by: Kever Yang <kever.yang@xxxxxxxxxxxxxx>
> [rebase, squash and reword commit message]
> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
> 
> and will apply that if you don't shout in the next hour or so :-)

LGTM.

-- Sebastian

Attachment: signature.asc
Description: PGP signature