Re: [PATCH] maple_tree: Fix handle of invalidated state in mas_wr_store_setup()

From: Liam Howlett
Date: Tue Jan 10 2023 - 09:22:05 EST


* SeongJae Park <sj@xxxxxxxxxx> [230109 18:43]:
> Hi Andrew,
>
> On Mon, 9 Jan 2023 15:40:12 -0800 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> > On Mon, 9 Jan 2023 19:22:48 +0000 SeongJae Park <sj@xxxxxxxxxx> wrote:
> >
> > > On Mon, 9 Jan 2023 16:55:42 +0000 Liam Howlett <liam.howlett@xxxxxxxxxx> wrote:
> > >
> > > > If an invalidated maple state is encountered during write, reset the
> > > > maple state to MAS_START. This will result in a re-walk of the tree to
> > > > the correct location for the write.
> >
> > Can we think of a Fixes: for this?

It wasn't really an issue until I wrote the vma iterator store
function.

You can put this before (mm-unstable git id..)
9df3d25a97ec ("mm: expand vma iterator interface")

> >
> > > > Link: https://lore.kernel.org/all/20230107020126.1627-1-sj@xxxxxxxxxx/
> > > > Reported-by: SeongJae Park <sj@xxxxxxxxxx>
> > > > Signed-off-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>
> > >
> > > Tested-by: SeongJae Park <sj@xxxxxxxxxx>
> > >
> > > I confirmed this patch fixes the boot failure issue. Nevertheless, the 'make
> > > install' issue on my system is still not fixed.
> >
> > Is this a mainline issue or an mm-unstable issue?
>
> It's mm-unstable issue:
> https://lore.kernel.org/linux-mm/20230107023954.1841-1-sj@xxxxxxxxxx/

Yes, just mm-unstable.