Re: [PATCH v8 11/16] x86/virt/tdx: Designate reserved areas for all TDMRs

[Huang, Kai]

On Mon, 2023-01-09 at 17:22 -0800, Dave Hansen wrote:
> On 1/9/23 17:19, Huang, Kai wrote:
> > > It's probably also worth noting *somewhere* that there's a balance to be
> > > had between TDMRs and reserved areas.  A system that is running out of
> > > reserved areas in a TDMR could split a TDMR to get more reserved areas.
> > > A system that has run out of TDMRs could relatively easily coalesce two
> > > adjacent TDMRs (before the PAMTs are allocated) and use a reserved area
> > > if there was a gap between them.
> > We can add above to the changelog of this patch, or the patch 09 ("x86/virt/tdx:
> > Fill out TDMRs to cover all TDX memory regions").  The latter perhaps is better
> > since that patch is the first place where the balance of TDMRs and reserved
> > areas is related.
> > 
> > What is your suggestion?
> 
> Just put it close to the code that actually hits the problem so the
> potential solution is close at hand to whoever hits the problem.
> 

Sorry to double check: the code which hits the problem is the 'if (idx >=
max_reserved_per_tdmr)' check in tdmr_add_rsvd_area(), so I think I can add
right before this check?