Re: [PATCH V2 01/11] dt-bindings: remoteproc: qcom,q6v5: Move MSM8996 to schema

[Krzysztof Kozlowski]

On 09/01/2023 04:48, Sibi Sankar wrote:
> Convert MSM8996 and similar (MSM8998/SDM845) MSS PIL bindings to schema.
> 
> Signed-off-by: Sibi Sankar <quic_sibis@xxxxxxxxxxx>
> ---
>  .../remoteproc/qcom,msm8996-mss-pil.yaml      | 370 ++++++++++++++++++
>  .../bindings/remoteproc/qcom,q6v5.txt         | 137 +------
>  2 files changed, 375 insertions(+), 132 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
> new file mode 100644
> index 000000000000..d3d3fb2fe91d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml
> @@ -0,0 +1,370 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/remoteproc/qcom,msm8996-mss-pil.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm MSM8996 MSS Peripheral Image Loader (and similar)
> +
> +maintainers:
> +  - Bjorn Andersson <andersson@xxxxxxxxxx>
> +  - Sibi Sankar <quic_sibis@xxxxxxxxxxx>
> +
> +description:
> +  This document describes the hardware for a component that loads and boots firmware
> +  on the Qualcomm Technology Inc. MSM8996 Modem Hexagon Core (and similar).

MSS Peripheral Image Loader loads and boots firmware
on the Qualcomm Technology Inc. MSM8996 Modem Hexagon Core (and similar).

> +
> +properties:
> +  compatible:
> +    oneOf:

It's not oneOf. Just enum.


> +      - enum:
> +          - qcom,msm8996-mss-pil
> +          - qcom,msm8998-mss-pil
> +          - qcom,sdm845-mss-pil
> +

With both above:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>


Best regards,
Krzysztof