Re: [PATCH 1/2] of: create of_root if no dtb provided

From: Clément Léger
Date: Tue Jan 10 2023 - 03:11:42 EST


Le Tue, 10 Jan 2023 00:27:16 -0600,
Frank Rowand <frowand.list@xxxxxxxxx> a écrit :

> On 1/9/23 02:40, Clément Léger wrote:
> > Le Tue, 11 Oct 2022 09:26:54 +0200,
> > Clément Léger <clement.leger@xxxxxxxxxxx> a écrit :
> >
> >> Le Fri, 24 Jun 2022 11:44:07 -0500,
> >> Frank Rowand <frowand.list@xxxxxxxxx> a écrit :
> >>
> >>> On 6/24/22 08:13, Clément Léger wrote:
> >>>> Le Thu, 23 Jun 2022 22:43:26 -0500,
> >>>> frowand.list@xxxxxxxxx a écrit :
> >>>>
> >>>>>
> >>>>> +/*
> >>>>> + * __dtb_empty_root_begin[] magically created by cmd_dt_S_dtb in
> >>>>> + * scripts/Makefile.lib
> >>>>> + */
> >>>>> +extern void *__dtb_empty_root_begin;
> >>>>> +
> >>>>> /*
> >>>>> * of_fdt_limit_memory - limit the number of regions in the /memory node
> >>>>> * @limit: maximum entries
> >>>>> @@ -1332,8 +1338,13 @@ bool __init early_init_dt_scan(void *params)
> >>>>> */
> >>>>> void __init unflatten_device_tree(void)
> >>>>> {
> >>>>
> >>
> >>
> >> Any news on this series ?
> >>
> >
> > Hi Frank,
> >
> > Do you plan on resubmitting this series ? If not, could I resubmit it
> > after fixing problems that were raised in the review ?
> >> Thanks,
> >
>
> Thanks for the prod. I'll re-spin it.

Ok great, thanks Frank.

>
> If I properly captured all the comments, I'll have to implement
> Rob's suggestion:
>
> "either CONFIG_OF_FLATTREE or CONFIG_OF_EARLY_FLATTREE will need
> to become user selectable."

>
> -Frank



--
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com