Re: [PATCH v1 10/13] soc: mediatek: mtk-svs: restore default voltages when svs init02 fail

[Roger Lu (陸瑞傑)]

Hi AngeloGioacchino,

Sorry for the late reply and thanks for the advices always.

On Tue, 2023-01-03 at 13:49 +0100, AngeloGioacchino Del Regno wrote:
> Il 26/12/22 10:42, Roger Lu ha scritto:
> > If svs init02 fail, it means we cannot rely on svs bank voltages anymore.
> > We need to disable svs function and restore DVFS opp voltages back to the
> > default voltages for making sure we have enough DVFS voltages.
> > 
> > Signed-off-by: Roger Lu <roger.lu@xxxxxxxxxxxx>
> 
> This needs a Fixes tag... and it also needs to apply to older kernels, as
> MT8183 does use SVS in previous versions.

No problem. I'll add a Fixes tag.

> 
> Perhaps you can send a different patch, without the cleanups, only for the
> backport?
> Otherwise you'll have to duplicate
> svs_bank_disable_and_restore_default_volts()
> again before cleaning up...
> 
> I'll leave the choice to you.


I'll reorder the patch to put cleanup patches first and fix patches next in the
patchset. Thanks for the advice again.

> 
> Regards,
> Angelo