Re: [PATCH] lib/scatterlist: Fix to calculate the last_pg properly

From: Jens Axboe
Date: Mon Jan 09 2023 - 22:19:39 EST


On 1/9/23 7:47 AM, Yishai Hadas wrote:
> The last_pg is wrong, it is actually the first page of the last
> scatterlist element. To get the last page of the last scatterlist
> element we have to add prv->length. So it is checking mergability
> against the wrong page, Further, a SG element is not guaranteed to end
> on a page boundary, so we have to check the sub page location also for
> merge eligibility.
>
> Fix the above by checking physical contiguity, compute the actual last
> page and then call pages_are_mergable().

Reviewed-by: Jens Axboe <axboe@xxxxxxxxx>

Andrew, can you pick this one up?

--
Jens Axboe