Re: [PATCH v3] tracing/eprobe: no need to check for negative ret value for snprintf

[Google]

On Mon, 9 Jan 2023 10:12:26 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Mon, 9 Jan 2023 23:59:13 +0900
> Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> wrote:
> 
> > On Mon,  9 Jan 2023 12:06:25 +0800
> > Quanfa Fu <quanfafu@xxxxxxxxx> wrote:
> > 
> > > No need to check for negative return value from snprintf() as the
> > > code does not return negative values.
> > >   
> > 
> > Thanks for simplifying, this looks good to me.
> > 
> > Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
> 
> Reviewed-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>
> 
> Masami, do you want to take it into the probes branch, or do you want me to
> take it into the tracing branch?

Yes, I'll take it to probe/for-next.

Thank you!

> 
> -- Steve
> 
> 
> > 
> > > Signed-off-by: Quanfa Fu <quanfafu@xxxxxxxxx>
> > > 


-- 
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>