RE: [PATCH bpf-next v1] bpf: Remove the unnecessary insn buffer comparison

[Wang, Haiyue]

> -----Original Message-----
> From: sdf@xxxxxxxxxx <sdf@xxxxxxxxxx>
> Sent: Tuesday, January 10, 2023 01:39
> To: Wang, Haiyue <haiyue.wang@xxxxxxxxx>
> Cc: bpf@xxxxxxxxxxxxxxx; Alexei Starovoitov <ast@xxxxxxxxxx>; Daniel Borkmann <daniel@xxxxxxxxxxxxx>;
> Andrii Nakryiko <andrii@xxxxxxxxxx>; Martin KaFai Lau <martin.lau@xxxxxxxxx>; Song Liu
> <song@xxxxxxxxxx>; Yonghong Song <yhs@xxxxxx>; John Fastabend <john.fastabend@xxxxxxxxx>; KP Singh
> <kpsingh@xxxxxxxxxx>; Hao Luo <haoluo@xxxxxxxxxx>; Jiri Olsa <jolsa@xxxxxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH bpf-next v1] bpf: Remove the unnecessary insn buffer comparison
> 
> On 01/08, Haiyue Wang wrote:
> > The variable 'insn' is initialized to 'insn_buf' without being changed,
> > only some helper macros are defined, so the insn buffer comparison is
> > unnecessary, just remove it.
> 
> > Signed-off-by: Haiyue Wang <haiyue.wang@xxxxxxxxx>
> 
> Acked-by: Stanislav Fomichev <sdf@xxxxxxxxxx>
> 
> Looks like these should have been removed as part of commit 2377b81de527
> ("bpf: split shared bpf_tcp_sock and bpf_sock_ops implementation").
> 

Thanks for the information, yes, it was missed. ;-)

> > ---
> >   net/core/filter.c | 6 ------
> >   1 file changed, 6 deletions(-)
> 


> > --
> > 2.39.0