Re: [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness()

From: Sam Ravnborg
Date: Mon Jan 09 2023 - 13:23:39 EST


Hi Christophe,
On Mon, Jan 09, 2023 at 05:44:46PM +0000, Christophe Leroy wrote:
>
>
> Le 07/01/2023 à 19:26, Sam Ravnborg via B4 Submission Endpoint a écrit :
> > From: Sam Ravnborg <sam@xxxxxxxxxxxx>
> >
> > Introduce backlight_get_brightness() to simplify logic
> > and avoid direct access to backlight properties.
>
> When I read 'introduce' I understand that you are adding a new function.
>
> In fact backlight_get_brightness() already exists, so maybe replace
> 'introduce' by 'use'

Thanks for your feedback. A similar patch is already applied to the
fbdev tree, so this patch can be ignored.

Sam