Re: [PATCH] soundwire: intel: remove DAI startup/shutdown

[Vinod Koul]

On 15-12-22, 16:54, Bard Liao wrote:
> From: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> 
> The only thing these DAI startup/shutdown callbacks do is play with
> pm_runtime reference counts.
> 
> This is not wrong, but it's not necessary at all. At the ASoC core level,
> only the component matters for pm_runtime. The ASoC core already calls
> pm_runtime_get_sync() in snd_soc_pcm_component_pm_runtime_get(),
> before the DAI startup callback is invoked.
> 
> None of the SoundWire codec drivers rely on pm_runtime helpers in
> their DAI startup/shutdown either. This adds to the evidence that only
> the component, or more precisely the device specified when registering
> a component, should deal with pm_runtime transitions.
> 
> Beyond the code cleanup, this move prepares for the addition of link
> power management in the auxiliary device startup/resume/suspend
> callbacks. The DAI callbacks can by-design assume that the device is
> already pm_runtime active.

Applied, thanks

-- 
~Vinod