Re: [PATCH net v4] af_unix: selftest: Fix the size of the parameter to connect()

[Mirsad Goran Todorovac]

On 9.1.2023. 2:15, Kuniyuki Iwashima wrote:
> From:   Mirsad Goran Todorovac <mirsad.todorovac@xxxxxx>
> Date:   Sat, 7 Jan 2023 04:40:20 +0100 (CET)
> > From: Mirsad Goran Todorovac <mirsad.todorovac@xxxxxxxxxxxx>
> >
> > Adjust size parameter in connect() to match the type of the parameter, to
> > fix "No such file or directory" error in selftests/net/af_unix/
> > test_oob_unix.c:127.
> >
> > The existing code happens to work provided that the autogenerated pathname
> > is shorter than sizeof (struct sockaddr), which is why it hasn't been
> > noticed earlier.
> >
> > Visible from the trace excerpt:
> >
> > bind(3, {sa_family=AF_UNIX, sun_path="unix_oob_453059"}, 110) = 0
> > clone(child_stack=NULL, flags=CLONE_CHILD_CLEARTID|CLONE_CHILD_SETTID|SIGCHLD, child_tidptr=0x7fa6a6577a10) = 453060
> > [pid <child>] connect(6, {sa_family=AF_UNIX, sun_path="unix_oob_45305"}, 16) = -1 ENOENT (No such file or directory)
> >
> > BUG: The filename is trimmed to sizeof (struct sockaddr).
> >
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > Cc: Eric Dumazet <edumazet@xxxxxxxxxx>
> > Cc: Jakub Kicinski <kuba@xxxxxxxxxx>
> > Cc: Paolo Abeni <pabeni@xxxxxxxxxx>
> > Cc: Shuah Khan <shuah@xxxxxxxxxx>
> > Cc: Kuniyuki Iwashima <kuniyu@xxxxxxxxxxxx>
> > Cc: Florian Westphal <fw@xxxxxxxxx>
> > Reviewed-by: Florian Westphal <fw@xxxxxxxxx>
> > Fixes: 314001f0bf92 ("af_unix: Add OOB support")
> > Signed-off-by: Mirsad Goran Todorovac <mirsad.todorovac@xxxxxxxxxxxx>
>
> Reviewed-by: Kuniyuki Iwashima <kuniyu@xxxxxxxxxx>
>
> You can check the current status here.
> https://patchwork.kernel.org/project/netdevbpf/patch/alpine.DEB.2.21.2301070437400.26826@xxxxxxxxxxxx/

Thank you very much for your time on this, Koniyuki, Jakub.

> PS: you may want to check config not to send a mail as multipart next time.

Done! Thanks for the hint. This should work:

  [ Sending Preferences ]
      [X]  Do Not Generate Sender Header
      [ ]  Use Sender Instead of X-X-Sender
      [X]  Do Not Send Flowed Text
      [X]  Downgrade Multipart to Text

Maybe add this to Documentation/process/email-clients.rst, section 
Alpine? It could save some round-trips ...

Thanks,
Mirsad

--
Mirsad Todorovac
System engineer
Faculty of Graphic Arts | Academy of Fine Arts
University of Zagreb
Republic of Croatia, the European Union
--
Sistem inženjer
Grafički fakultet | Akademija likovnih umjetnosti
Sveučilište u Zagrebu