Re: [PATCH 0/8] HID: remove some unneeded exported symbols from hid.h

From: Hans de Goede
Date: Mon Jan 09 2023 - 03:40:36 EST


Hi,

On 12/22/22 06:10, Thomas Weißschuh wrote:
> Small cleanup to get rid of exports of the lowlevel hid drivers and to make
> them const.

Thanks, the entire series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

for the series.

Regards,

Hans


>
> To: Hans de Goede <hdegoede@xxxxxxxxxx>
> To: Jiri Kosina <jikos@xxxxxxxxxx>
> To: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx>
> To: David Rheinsberg <david.rheinsberg@xxxxxxxxx>
> To: Marcel Holtmann <marcel@xxxxxxxxxxxx>
> To: Johan Hedberg <johan.hedberg@xxxxxxxxx>
> To: Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx>
> To: "David S. Miller" <davem@xxxxxxxxxxxxx>
> To: Eric Dumazet <edumazet@xxxxxxxxxx>
> To: Jakub Kicinski <kuba@xxxxxxxxxx>
> To: Paolo Abeni <pabeni@xxxxxxxxxx>
> Cc: linux-input@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Cc: linux-bluetooth@xxxxxxxxxxxxxxx
> Cc: netdev@xxxxxxxxxxxxxxx
>
> ---
> Thomas Weißschuh (8):
> HID: letsketch: Use hid_is_usb()
> HID: usbhid: Make hid_is_usb() non-inline
> HID: Remove unused function hid_is_using_ll_driver()
> HID: Unexport struct usb_hid_driver
> HID: Unexport struct uhid_hid_driver
> HID: Unexport struct hidp_hid_driver
> HID: Unexport struct i2c_hid_ll_driver
> HID: Make lowlevel driver structs const
>
> drivers/hid/hid-letsketch.c | 2 +-
> drivers/hid/i2c-hid/i2c-hid-core.c | 3 +--
> drivers/hid/uhid.c | 3 +--
> drivers/hid/usbhid/hid-core.c | 9 +++++++--
> include/linux/hid.h | 18 ++----------------
> net/bluetooth/hidp/core.c | 3 +--
> 6 files changed, 13 insertions(+), 25 deletions(-)
> ---
> base-commit: d264dd3bbbd16b56239e889023fbe49413a58eaf
> change-id: 20221222-hid-b9551f9fa236
>
> Best regards,