Re: [PATCH 1/2] clk: qcom: ipq8074: populate fw_name for usb3phy-s

From: Robert Marko
Date: Sun Jan 08 2023 - 13:00:57 EST


On Sun, 8 Jan 2023 at 18:34, Dmitry Baryshkov
<dmitry.baryshkov@xxxxxxxxxx> wrote:
>
> On Sun, 8 Jan 2023 at 15:04, Robert Marko <robimarko@xxxxxxxxx> wrote:
> >
> > Having only .name populated in parent_data for clocks which are only
> > globally searchable currently will not work as the clk core won't copy
> > that name if there is no .fw_name present as well.
> >
> > So, populate .fw_name for usb3phy clocks in parent_data as they were
> > missed by me in ("clk: qcom: ipq8074: populate fw_name for all parents").
> >
> > Fixes: ae55ad32e273 ("clk: qcom: ipq8074: convert to parent data")
> > Signed-off-by: Robert Marko <robimarko@xxxxxxxxx>
>
> Ah, excuse me, this is what I asked for in the other patch. We can
> only hope to see these clocks added to the gcc DT node.

Yes, there are PCI pipe parenting fixes waiting for review, so I plan to add
both to GCC node after that.

It would be great if you can take a look at the IPQ8074 PCI support series.

Regards,
Robert
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
>
>
> --
> With best wishes
> Dmitry