Re: [PATCHv3 09/12] dmapool: simplify freeing

From: Christoph Hellwig
Date: Sun Jan 08 2023 - 12:08:34 EST


> - * DMA Pool allocator
> +* DMA Pool allocator

This got corrupted somehow.

> + if (!is_page_busy(page))
> + dma_free_coherent(pool->dev, pool->allocation,
> + page->vaddr, page->dma);
> + else
> dev_err(pool->dev, "%s %s, %p busy\n", __func__,
> pool->name, page->vaddr);
> + list_del(&page->page_list);
> + kfree(page);

I'm still not sure what the point of leaking the page in case it is
busy vs letting KASAN and friends actually catch it, but the pure
rearrangement is an improvement over the previous state, so:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>