Re: [PATCH v2 1/7] kbuild: refactor host*_flags

[Masahiro Yamada]

On Sun, Jan 8, 2023 at 12:12 AM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Sat, Jan 7, 2023 at 10:18 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> >
> > Remove _host*_flags.
> >
> > This will change the -Wp,-MMD,$(depfile) order in the command line
> > but no functional change is intended.
>
> Looks fine to me. I gave it a quick test with just this patch on top
> of v6.2-rc2 and checked that the order indeed changed (was there a
> reason to not keep it the same?).


No, there is no reason. Just my whimsy.

I will do something like the following just in case.

hostc_flags  =  -Wp,-MMD,$(depfile)  \
                $(KBUILD_HOSTCFLAGS) $(HOST_EXTRACFLAGS) \
                $(HOSTCFLAGS_$(target-stem).o)

>
> Reviewed-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> Tested-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
>
> Thanks!
>
> Cheers,
> Miguel



-- 
Best Regards
Masahiro Yamada