Re: [PATCH 12/15] auxdisplay: ht16k33: Introduce backlight_get_brightness()

From: Sam Ravnborg
Date: Sun Jan 08 2023 - 04:30:40 EST


Hi Robin.

On Sat, Jan 07, 2023 at 10:02:38PM +0100, Miguel Ojeda wrote:
> On Sat, Jan 7, 2023 at 7:26 PM Sam Ravnborg via B4 Submission Endpoint
> <devnull+sam.ravnborg.org@xxxxxxxxxx> wrote:
> >
> > Introduce backlight_get_brightness() to simplify logic
> > and avoid direct access to backlight properties.
>
> Note: Stephen sent this one too a while ago (with some more details in
> the commit message, which is always nice); and then he sent yesterday
> v2 [1] (to mention the functional change with `BL_CORE_SUSPENDED`
> [2]).
Thanks for the pointers. I will try to move forward with Stephen's
patches.
>
> Anyway, if it goes via drm-misc, feel free to have my:
>
> Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
>
> Though it would be nice to have Robin test the change.

Robin - can I get your ack to apply Stephen's original v2 patch to
drm-misc?

Sam

>
> Thanks!
>
> [1] https://lore.kernel.org/lkml/20230106143002.1434266-1-steve@xxxxxxx/
> [2] https://lore.kernel.org/lkml/CANiq72kRhmT37H1FAGYGny83ONYXeqJuO8ZPbym0ajQOWKY4Kw@xxxxxxxxxxxxxx/
>
> Cheers,
> Miguel