Re: [PATCH] drm/msm: Add missing check and destroy for alloc_ordered_workqueue

From: Dmitry Baryshkov
Date: Fri Jan 06 2023 - 03:11:34 EST


On Fri, 6 Jan 2023 at 03:38, Jiasheng Jiang <jiasheng@xxxxxxxxxxx> wrote:
>
> Add check for the return value of alloc_ordered_workqueue as it may return
> NULL pointer.
> Moreover, use the destroy_workqueue in the later fails in order to avoid
> memory leak.
>
> Fixes: c8afe684c95c ("drm/msm: basic KMS driver for snapdragon")
> Signed-off-by: Jiasheng Jiang <jiasheng@xxxxxxxxxxx>

Please resend the patch, including freedreno@ to the cc list.

> ---
> drivers/gpu/drm/msm/msm_drv.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)



--
With best wishes
Dmitry