Re: [PATCH] arm64/uprobes: change the uprobe_opcode_t typedef to fix the sparse warning

From: Will Deacon
Date: Thu Jan 05 2023 - 13:05:17 EST


On Wed, 28 Dec 2022 09:54:12 +0800 (CST), guo.ziliang@xxxxxxxxxx wrote:
> From: junhua huang <huang.junhua@xxxxxxxxxx>
>
> After we fixed the uprobe inst endian in aarch_be, the sparse check report
> the following warning info:
>
> sparse warnings: (new ones prefixed by >>)
> >> kernel/events/uprobes.c:223:25: sparse: sparse: restricted __le32 degrades to integer
> >> kernel/events/uprobes.c:574:56: sparse: sparse: incorrect type in argument 4 (different base types)
> @@ expected unsigned int [addressable] [usertype] opcode @@ got restricted __le32 [usertype] @@
> kernel/events/uprobes.c:574:56: sparse: expected unsigned int [addressable] [usertype] opcode
> kernel/events/uprobes.c:574:56: sparse: got restricted __le32 [usertype]
> >> kernel/events/uprobes.c:1483:32: sparse: sparse: incorrect type in initializer (different base types)
> @@ expected unsigned int [usertype] insn @@ got restricted __le32 [usertype] @@
> kernel/events/uprobes.c:1483:32: sparse: expected unsigned int [usertype] insn
> kernel/events/uprobes.c:1483:32: sparse: got restricted __le32 [usertype]
>
> [...]

Applied to arm64 (for-next/fixes), thanks!

[1/1] arm64/uprobes: change the uprobe_opcode_t typedef to fix the sparse warning
https://git.kernel.org/arm64/c/ef08c0fadd8a

Cheers,
--
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev