[PATCH v3 2/8] media: uvc: Allow quirking by entity guid

From: Ricardo Ribalda
Date: Wed Jan 04 2023 - 05:46:23 EST


When an IP is shared by multiple devices its erratas will be shared by
all of them. Instead of creating a long list of device quirks, or
waiting for the users to report errors in their hardware lets add a
routine to add quirks based on the entity guid.

Tested-by: HungNien Chen <hn.chen@xxxxxxxxxxxxx>
Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
---
drivers/media/usb/uvc/uvc_driver.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)

diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index bd3716a359b0..5448576a8413 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -1195,6 +1195,28 @@ static int uvc_parse_control(struct uvc_device *dev)
return 0;
}

+static const struct uvc_entity_quirk {
+ u8 guid[16];
+ u32 quirks;
+} uvc_entity_quirk[] = {
+};
+
+static void uvc_entity_quirks(struct uvc_device *dev)
+{
+ struct uvc_entity *entity;
+ unsigned int i;
+
+ list_for_each_entry(entity, &dev->entities, list) {
+ for (i = 0; i < ARRAY_SIZE(uvc_entity_quirk); i++) {
+ if (memcmp(entity->guid, uvc_entity_quirk[i].guid,
+ sizeof(entity->guid)) == 0) {
+ dev->quirks |= uvc_entity_quirk[i].quirks;
+ break;
+ }
+ }
+ }
+}
+
/* -----------------------------------------------------------------------------
* Privacy GPIO
*/
@@ -2154,6 +2176,9 @@ static int uvc_probe(struct usb_interface *intf,
goto error;
}

+ /* Apply entity based quirks */
+ uvc_entity_quirks(dev);
+
dev_info(&dev->udev->dev, "Found UVC %u.%02x device %s (%04x:%04x)\n",
dev->uvc_version >> 8, dev->uvc_version & 0xff,
udev->product ? udev->product : "<unnamed>",

--
2.39.0.314.g84b9a713c41-goog-b4-0.11.0-dev-696ae