Re: [PATCH] media: i2c: imx258: Parse and register properties

[Sakari Ailus]

Hi Jacopo, Robert,

On Tue, Jan 03, 2023 at 06:16:24PM +0100, Jacopo Mondi wrote:
> Hi Robert
> 
> On Tue, Jan 03, 2023 at 03:11:44PM +0100, Robert Mader wrote:
> > On 02.01.23 15:06, Jacopo Mondi wrote:
> > > Hi Robert
> > >
> > > On Sun, Dec 25, 2022 at 04:42:34PM +0100, Robert Mader wrote:
> > > > Analogous to e.g. the imx219. This enables propagating
> > > > V4L2_CID_CAMERA_SENSOR_ROTATION values so that libcamera
> > > > can detect the correct rotation from the device tree
> > > > and propagate it further to e.g. Pipewire.
> > > >
> > > > Signed-off-by: Robert Mader <robert.mader@xxxxxxxxxxxxx>
> > > > ---
> > > >   drivers/media/i2c/imx258.c | 13 ++++++++++++-
> > > >   1 file changed, 12 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c
> > > > index eab5fc1ee2f7..85819043d1e3 100644
> > > > --- a/drivers/media/i2c/imx258.c
> > > > +++ b/drivers/media/i2c/imx258.c
> > > > @@ -9,6 +9,7 @@
> > > >   #include <linux/pm_runtime.h>
> > > >   #include <media/v4l2-ctrls.h>
> > > >   #include <media/v4l2-device.h>
> > > > +#include <media/v4l2-fwnode.h>
> > > >   #include <asm/unaligned.h>
> > > >
> > > >   #define IMX258_REG_VALUE_08BIT		1
> > > > @@ -1149,6 +1150,7 @@ static int imx258_init_controls(struct imx258 *imx258)
> > > >   {
> > > >   	struct i2c_client *client = v4l2_get_subdevdata(&imx258->sd);
> > > >   	struct v4l2_ctrl_handler *ctrl_hdlr;
> > > > +	struct v4l2_fwnode_device_properties props;
> > > Might be nicer to move this one line up
> >
> >  Can you say what's your reasoning? I personally slightly prefer
> > alphabetical order, but no strong opinion :)
> >
> 
> I've often been instructed to try to respect the inverse-xmas-tree

I'd advise the same, unless there are other reasons to arrange the lines
differently.

-- 
Kind regards,

Sakari Ailus