Re: [PATCH 5/6] arm64: dts: qcom: sm8250-mtp: fix wcd938x codec node

From: Johan Hovold
Date: Mon Jan 02 2023 - 10:28:20 EST


On Mon, Jan 02, 2023 at 04:22:30PM +0100, Krzysztof Kozlowski wrote:
> On 02/01/2023 16:18, Johan Hovold wrote:
> > On Mon, Jan 02, 2023 at 04:09:14PM +0100, Krzysztof Kozlowski wrote:
> >> On 02/01/2023 16:03, Johan Hovold wrote:
> >>> On Mon, Jan 02, 2023 at 01:20:03PM +0100, Krzysztof Kozlowski wrote:
> >>>> On 02/01/2023 11:50, Johan Hovold wrote:
> >>>>> The wcd938x codec is not a memory-mapped device and does not belong
> >>>>> under the soc node.
> >>>>>
> >>>>> Move the node to the root node to avoid DT validation failures.
> >>>>>
> >>>>> Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> >>>>> ---
> >>>>> arch/arm64/boot/dts/qcom/sm8250-mtp.dts | 40 ++++++++++++-------------
> >>>>> 1 file changed, 19 insertions(+), 21 deletions(-)
> >>>>
> >>>> Don't you base on some older tree? It was alreadt moved. Maybe other
> >>>> changes were also implemented...
> >>>
> >>> If you've moved this node is hasn't made it into linux-next (or the qcom
> >>> tree) yet.
> >>
> >> So you need to update your tree/rebase as this is already in Qualcomm
> >> tree. There was no linux-next release since a week, so that's not a
> >> solution.
> >
> > As I wrote above, it's not in the qcom tree either.
>
> Really?
>
> https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/commit/?h=for-next&id=e5b8c08245307a82cdf180cd5d385a34ba1cfd9d

Sorry, most have looked at on old branch or something.

Johan