Re: [PATCH v3 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings

[Roger Quadros]

On 23/12/2022 16:28, Andrew Lunn wrote:
>> +        ethernet-ports {
>> +            #address-cells = <1>;
>> +            #size-cells = <0>;
>> +            pruss2_emac0: port@0 {
>> +                reg = <0>;
>> +                phy-handle = <&pruss2_eth0_phy>;
>> +                phy-mode = "rgmii-rxid";
> 
> That is unusual. Where are the TX delays coming from?

>From the below property

+                ti,syscon-rgmii-delay = <&scm_conf 0x4120>;

The TX delay can be enabled/disabled from within the ICSSG block.

If this property exists and PHY mode is neither PHY_INTERFACE_MODE_RGMII_ID
nor PHY_INTERFACE_MODE_RGMII_TXID then the internal delay is enabled.

This logic is in prueth_config_rgmiidelay() function in the introduced driver.

> 
>      Andrew

cheers,
-roger