Re: [PATCH 3/3] arm64: dts: qcom: sm8250: Sort audio hw nodes

From: Krzysztof Kozlowski
Date: Fri Dec 30 2022 - 11:10:29 EST


On 30/12/2022 14:50, Konrad Dybcio wrote:
> Half of the audio hardware nodes were not sorted properly. Fix that.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---


Just a note:

> + wsamacro: codec@3240000 {
> + compatible = "qcom,sm8250-lpass-wsa-macro";
> + reg = <0 0x03240000 0 0x1000>;
> + clocks = <&audiocc LPASS_CDC_WSA_MCLK>,
> + <&audiocc LPASS_CDC_WSA_NPL>,
> + <&q6afecc LPASS_HW_MACRO_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> + <&q6afecc LPASS_HW_DCODEC_VOTE LPASS_CLK_ATTRIBUTE_COUPLE_NO>,
> + <&aoncc LPASS_CDC_VA_MCLK>,
> + <&vamacro>;
> + clock-names = "mclk",
> + "npl",
> + "macro",
> + "dcodec",
> + "va",
> + "fsgen";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&wsa_swr_active>;
> +
> + #clock-cells = <0>;
> + clock-frequency = <9600000>;

This will conflict:
https://lore.kernel.org/all/20221224154255.43499-3-krzysztof.kozlowski@xxxxxxxxxx/

https://lore.kernel.org/all/20221225115844.55126-3-krzysztof.kozlowski@xxxxxxxxxx/

Best regards,
Krzysztof