Re: [PATCH linux-next] ecryptfs: crypto: use strscpy() to instead of strncpy()

From: Eric Biggers
Date: Thu Dec 29 2022 - 15:52:03 EST


On Wed, Dec 28, 2022 at 09:36:54AM +0800, yang.yang29@xxxxxxxxxx wrote:
> From: Xu Panda <xu.panda@xxxxxxxxxx>
>
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL-terminated strings.

Unlike strncpy(), strscpy() does not initialize the full destination array, so
it is unsafe in some situations, such as initializing structures that are then
copied to userspace or to disk. Please include an actual explanation for why
this patch is correct.

- Eric