Re: [PATCH v2] RDMA/srp (gcc13): move large values to a new enum

From: Leon Romanovsky
Date: Thu Dec 29 2022 - 02:10:29 EST


On Mon, 12 Dec 2022 13:04:11 +0100, Jiri Slaby (SUSE) wrote:
> Since gcc13, each member of an enum has the same type as the enum [1]. And
> that is inherited from its members. Provided these two:
> SRP_TAG_NO_REQ = ~0U,
> SRP_TAG_TSK_MGMT = 1U << 31
> all other members are unsigned ints.
>
> Esp. with SRP_MAX_SGE and SRP_TSK_MGMT_SQ_SIZE and their use in min(),
> this results in the following warnings:
> include/linux/minmax.h:20:35: error: comparison of distinct pointer types lacks a cast
> drivers/infiniband/ulp/srp/ib_srp.c:563:42: note: in expansion of macro 'min'
>
> [...]

Applied, thanks!

[1/1] RDMA/srp (gcc13): move large values to a new enum
https://git.kernel.org/rdma/rdma/c/fb5b88f5b78192

Best regards,
--
Leon Romanovsky <leon@xxxxxxxxxx>