Re: [PATCH v2 1/6] x86/microcode/core: Move microcode_check() to cpu/microcode/core.c

From: Ashok Raj
Date: Tue Dec 27 2022 - 14:59:41 EST


On Tue, Dec 27, 2022 at 08:50:25PM +0100, Borislav Petkov wrote:
> On Tue, Dec 27, 2022 at 11:23:35AM -0800, Ashok Raj wrote:
> > microcode_check() is only called from microcode/core.c. Move it and make
> > it static to prepare for upcoming fix for false negative when checking CPU
> > features after a microcode update. Also move get_cpu_cap() to processor.h
> > for general use outside of arch/x86/kernel/cpu/cpu.h
>
> I thought we agreed not to do this:
>
> https://lore.kernel.org/r/Y44bbZMMf8I6Lzl/@zn.tnic
>
> Or was this a misunderstanding?

Bah... you are correct, I should drop this one.

I'll fix it up

Cheers,
Ashok