Re: [PATCH v5 3/6] coresight: configfs: Add in binary attributes to load files

From: Christoph Hellwig
Date: Tue Dec 27 2022 - 12:09:55 EST


On Mon, Dec 19, 2022 at 11:46:35PM +0000, Mike Leach wrote:
> Add in functionality and binary attribute to load and unload
> configurations as binary data.
>
> Files are loaded via the 'load' binary attribute. System reads the incoming
> file, which must be formatted correctly as defined in the file reader code.
> This will create configuration(s) and/or feature(s) and load them
> into the system.

Binary attributes are intended to pass things such as firmware
through. Defining your own structured file format seems like a
major abuse of the configfs design. What's the advantage of this
over simply using an ioctl?