Re: [PATCH v9 1/4] crypto: ccp - Name -1 return value as SEV_RET_NO_FW_CALL

[Tom Lendacky]

On 12/22/22 09:31, Borislav Petkov wrote:
> On Wed, Dec 07, 2022 at 01:02:07AM +0000, Dionna Glaze wrote:
> > From: Peter Gonda <pgonda@xxxxxxxxxx>
> >
> > The PSP can return a "firmware error" code of -1 in circumstances where
> > the PSP is not actually called. To make this protocol unambiguous, the
> > value is named SEV_RET_NO_FW_CALL.
> >
> > Cc: Thomas Lendacky <Thomas.Lendacky@xxxxxxx>
> > Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> > Cc: Joerg Roedel <jroedel@xxxxxxx>
> > Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> > Cc: Andy Lutomirsky <luto@xxxxxxxxxx>
> > Cc: John Allen <john.allen@xxxxxxx>
> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> > Cc: Borislav Petkov <bp@xxxxxxxxx>
> >
> > Signed-off-by: Peter Gonda <pgonda@xxxxxxxxxx>
> > Signed-off-by: Dionna Glaze <dionnaglaze@xxxxxxxxxx>
> > ---
> >   Documentation/virt/coco/sev-guest.rst |  2 +-
> >   drivers/crypto/ccp/sev-dev.c          | 22 ++++++++++++++--------
> >   include/uapi/linux/psp-sev.h          |  7 +++++++
> >   3 files changed, 22 insertions(+), 9 deletions(-)
>
> Looks good, did some minor touch ups ontop, see below.
>
> @Tom: Ack/Rev-by?

Acked-by: Tom Lendacky <thomas.lendacky@xxxxxxx>

> @Herbert: ok to carry this through tip?
>
> Thx.