Re: [PATCH v2 0/4] perf vendor events amd: Add Zen 4 events and metrics

[Arnaldo Carvalho de Melo]

Em Wed, Dec 14, 2022 at 07:59:01AM -0800, Ian Rogers escreveu:
> On Wed, Dec 14, 2022 at 12:27 AM Sandipan Das <sandipan.das@xxxxxxx> wrote:
> >
> > Add events and metrics taken from the Processor Programming Reference
> > (PPR) for AMD Family 19h Model 11h Revision B1 processors which can be
> > found at: https://www.amd.com/system/files/TechDocs/55901_0.25.zip
> >
> > Previous versions can be found at:
> > v1: https://lore.kernel.org/all/20221207053007.336806-1-sandipan.das@xxxxxxx/
> >
> > Changes in v2:
> > - Remove "bytes" from the names of data fabric bandwidth metrics which
> >   use a scale unit.
> > - Use better group names for pipeline utilization metrics.
> > - Move patch that adds family-model mapping to the end of the series for
> >   avoiding potential build issues.
> >
> > Sandipan Das (4):
> >   perf vendor events amd: Add Zen 4 core events
> >   perf vendor events amd: Add Zen 4 uncore events
> >   perf vendor events amd: Add Zen 4 metrics
> >   perf vendor events amd: Add Zen 4 mapping
> 
> Series: Acked-by: Ian Rogers <irogers@xxxxxxxxxx>

Please add the Acked-by:  on a separate line, like

Series:
Acked-by: Ian Rogers <irogers@xxxxxxxxxx>

To avoid confusing b4

Thanks,

- Arnaldo
 
> Thanks,
> Ian
> 
> >  .../pmu-events/arch/x86/amdzen4/branch.json   |   82 ++
> >  .../pmu-events/arch/x86/amdzen4/cache.json    |  772 ++++++++++++
> >  .../pmu-events/arch/x86/amdzen4/core.json     |  122 ++
> >  .../arch/x86/amdzen4/data-fabric.json         | 1090 +++++++++++++++++
> >  .../arch/x86/amdzen4/floating-point.json      |  818 +++++++++++++
> >  .../pmu-events/arch/x86/amdzen4/memory.json   |  174 +++
> >  .../pmu-events/arch/x86/amdzen4/other.json    |  138 +++
> >  .../pmu-events/arch/x86/amdzen4/pipeline.json |   98 ++
> >  .../arch/x86/amdzen4/recommended.json         |  334 +++++
> >  tools/perf/pmu-events/arch/x86/mapfile.csv    |    3 +-
> >  10 files changed, 3630 insertions(+), 1 deletion(-)
> >  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen4/branch.json
> >  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen4/cache.json
> >  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen4/core.json
> >  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen4/data-fabric.json
> >  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen4/floating-point.json
> >  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen4/memory.json
> >  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen4/other.json
> >  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen4/pipeline.json
> >  create mode 100644 tools/perf/pmu-events/arch/x86/amdzen4/recommended.json
> >
> > --
> > 2.34.1
> >

-- 

- Arnaldo