Re: [PATCH REPOST] f2fs: file: drop useless initializer in expand_inode_data()
From: Sergey Shtylyov
Date: Wed Dec 21 2022 - 09:46:30 EST
Hello!
On 12/21/22 6:30 AM, Yangtao Li wrote:
>> In expand_inode_data(), the 'new_size' local variable is initialized to
>> the result of i_size_read(), however this value isn't ever used, so we
>> can drop this initializer...
>>
>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static
>> analysis tool.
>>
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
>>
>> ---
>> This patch is against the 'dev' branch of Jaegeuk Kim's F2FS repo...
>> Reposting with ISP RAS mailing lists CC'ed now...
>
> Why do you repeatedly send a patch that cannot be applied,
Why (it does apply to your 'dev' branch)? Because of the merge window?
> and this does not have a CC on linux-kernel.vger.kernel.org.
I normnally avoid CCing LKML as my patches are not generally interesting
to the wide public (I think)...
> Otherwise, code modification looks good to me.
Thanx!
> Thx,
> Yangtao
MBR, Sergey