Re: [PATCH] hid: Support for Litra Glow

[Bastien Nocera]

On Fri, 2022-12-16 at 15:27 +0100, Bastien Nocera wrote:
> On Fri, 2022-12-16 at 10:53 +0100, Bastien Nocera wrote:
> > On Thu, 2022-12-15 at 22:09 +0100, Andreas Bergmeier wrote:
> > > Tries to implement as general support for Illumination Light as
> > > possible. Note that it is singular, which means by Logitech spec
> > > we
> > > are
> > > fine off with just handling one capability/device.
> > 
> > Your email client absolutely trashed the patch's indentation, it's
> > unreadable as-is.
> > 
> > > Implementation currently only exposes Brightness and On/Off
> > > controls.
> > > Does currently not expose Color Temperature because LEDs does not
> > > support it.
> > > 
> > > Introduces HIDPP_QUIRK_CLASS_SIMPLE_START to prevent reconnect on
> > > startup. Could not get Glow to work with that.
> > 
> > I'd really rather we didn't introduce a new quirk, but instead
> > fixed
> > the fact that we need to restart the HID transport to support 3 (!)
> > devices.
> > 
> > Would something like the attached patch work? I haven't tested it
> > yet,
> > but if it works for you, I'll test it on the devices I have here.
> 
> A tested version attached. I'll need to test it against a T650 before
> sending it for review.

I've tested it with a T650, and it works, so I sent it for review.

Would be great to know if it helps simplify your driver.

Cheers