Re: [PATCH] ath9k: use proper statements in conditionals

From: Toke Høiland-Jørgensen
Date: Fri Dec 16 2022 - 16:07:12 EST


Kalle Valo <kvalo@xxxxxxxxxx> writes:

> Toke Høiland-Jørgensen <toke@xxxxxxx> writes:
>
>> Arnd Bergmann <arnd@xxxxxxxxxx> writes:
>>
>>> From: Arnd Bergmann <arnd@xxxxxxxx>
>>>
>>> A previous cleanup patch accidentally broke some conditional
>>> expressions by replacing the safe "do {} while (0)" constructs
>>> with empty macros. gcc points this out when extra warnings
>>> are enabled:
>>>
>>> drivers/net/wireless/ath/ath9k/hif_usb.c: In function 'ath9k_skb_queue_complete':
>>> drivers/net/wireless/ath/ath9k/hif_usb.c:251:57: error: suggest braces around empty body in an 'else' statement [-Werror=empty-body]
>>> 251 | TX_STAT_INC(hif_dev, skb_failed);
>>>
>>> Make both sets of macros proper expressions again.
>>>
>>> Fixes: d7fc76039b74 ("ath9k: htc: clean up statistics macros")
>>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>>
>> Acked-by: Toke Høiland-Jørgensen <toke@xxxxxxx>
>
> I'll queue this to v6.2.

Sounds good, thanks!

-Toke