Re: [PATCH] mtd: dataflash: remove duplicate SPI ID table

[Uwe Kleine-König]

On Thu, Dec 15, 2022 at 05:47:30PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> Building with -Werror=override-init revealds that two patches added

s/revealds/reveals/

> the same device ID table to this driver:
> 
> drivers/mtd/devices/mtd_dataflash.c:946:27: error: initialized field overwritten [-Werror=override-init]
>   946 |         .id_table       = dataflash_spi_ids,
>       |                           ^~~~~~~~~~~~~~~~~
> drivers/mtd/devices/mtd_dataflash.c:946:27: note: (near initialization for 'dataflash_driver.id_table')
> 
> Remove one of the copies.
> 
> Fixes: 27a030e87292 ("mtd: dataflash: Add device-tree SPI IDs")
> Fixes: ac4f83482afb ("mtd: dataflash: Add SPI ID table")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

I seem to recall this was addressed already before. I found
https://lore.kernel.org/r/20221004211412.182940-1-colin.i.king@xxxxxxxxx
but it seems Colin (added to Cc:) never followed up on the build
problems reported by the build bots.

Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature