Re: [External] Re: [RFC PATCH] blk-throtl: Introduce sync queue for write ios

[Tejun Heo]

Hello,

Sorry about the delay.

On Tue, Dec 13, 2022 at 11:55:16AM +0800, hanjinke wrote:
> If sq->queue[] were only classfied SYNC and ASYNC, some things may become a
> little difficult to handle。As we put sync write and read together into SYNC
> queue, the two may influence each other.
> Whit wbps=1M and rbps=100M configured, sync io likely be throtled while read
> ios after it may can be dispatched within the limit. In that case,
> maybe we should scan the whole SYNC queue to check read io.

Ah, yeah, you're right. The configuration per-rw so we have to split within.
Will review your latest patch.

Thanks.

-- 
tejun