RE: [Intel-gfx] [PATCH] drm/i915/gt: Modify mismatched function name

From: Upadhyay, Tejas
Date: Tue Dec 13 2022 - 05:49:19 EST


Indeed looks like miss. Thanks for the patch.

Reviewed-by: Tejas Upadhyay <tejas.upadhyay@xxxxxxxxx>

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of
> Jiapeng Chong
> Sent: Tuesday, December 13, 2022 3:22 PM
> To: jani.nikula@xxxxxxxxxxxxxxx
> Cc: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>; intel-
> gfx@xxxxxxxxxxxxxxxxxxxxx; Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; daniel@xxxxxxxx;
> Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>; airlied@xxxxxxxxx
> Subject: [Intel-gfx] [PATCH] drm/i915/gt: Modify mismatched function name
>
> No functional modification involved.
>
> drivers/gpu/drm/i915/gt/intel_engine_cs.c:1306: warning: expecting
> prototype for intel_engines_init_common(). Prototype was for
> engine_init_common() instead.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3442
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> index c33e0d72d670..dfcd3a91fbe7 100644
> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> @@ -1292,7 +1292,7 @@ create_kernel_context(struct intel_engine_cs
> *engine) }
>
> /**
> - * intel_engines_init_common - initialize cengine state which might require
> hw access
> + * engine_init_common - initialize cengine state which might require hw
> + access
> * @engine: Engine to initialize.
> *
> * Initializes @engine@ structure members shared between legacy and
> execlists
> --
> 2.20.1.7.g153144c